Skip to content

Commit

Permalink
Merge #161
Browse files Browse the repository at this point in the history
161: Document missing ingress.className value in README.md r=alallema a=c0bra

# Pull Request

## What does this PR do?

The README.md is missing documentation of the `ingress.className` value.  If you mistakenly use an annotation like `kubernetes.io/ingress.class: nginx` you will get an error and scratch your head about how to address it.

## PR checklist
Please check if your PR fulfills the following requirements:
- [X] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [X] Have you read the contributing guidelines?
- [X] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Brian Hann <[email protected]>
  • Loading branch information
bors[bot] and c0bra authored Feb 16, 2023
2 parents 3fff54e + 5aa7be9 commit f57f155
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/meilisearch/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v1
appVersion: "v1.0.0"
description: A Helm chart for the Meilisearch search engine
name: meilisearch
version: 0.1.48
version: 0.1.49
icon: https://res.cloudinary.com/meilisearch/image/upload/v1597822872/Logo/logo_img.svg
home: https://github.com/meilisearch/meilisearch-kubernetes/charts
maintainers:
Expand Down
2 changes: 2 additions & 0 deletions charts/meilisearch/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ helm uninstall <your-service-name>
| | |
| `ingress.annotations` | Ingress annotations | `{}`
| | |
| `ingress.className` | Ingress ingressClassName | `nginx`
| | |
| `ingress.path` | Path within the host | `/`
| | |
| `ingress.hosts` | List of hostnames | `[meilisearch-example.local]`
Expand Down

0 comments on commit f57f155

Please sign in to comment.