Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to remove okurigana highlighting #1521

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tora-pan
Copy link
Contributor

Gives the user the ability to toggle (on/off) the highlighting of the okurigana via the extension options page.

fixes: #1120

options
noHighlightV2

@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.77%. Comparing base (667c4b8) to head (33b3cb6).
Report is 182 commits behind head on main.

Files with missing lines Patch % Lines
extension/data.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1521      +/-   ##
==========================================
- Coverage   81.78%   81.77%   -0.02%     
==========================================
  Files           8        8              
  Lines        2954     2957       +3     
  Branches      188      189       +1     
==========================================
+ Hits         2416     2418       +2     
- Misses        534      535       +1     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make red outlines around okurigana in kanji entries optional
1 participant