Skip to content

Commit

Permalink
remove windows from test runner - memmap doesn't work
Browse files Browse the repository at this point in the history
  • Loading branch information
dmeliza committed Aug 29, 2024
1 parent 2fb4c16 commit 9b1a4ef
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests-python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [macos-13, macos-14, ubuntu-latest, windows-latest]
os: [macos-13, macos-14, ubuntu-latest]
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]
exclude:
- os: macos-14
Expand Down
4 changes: 3 additions & 1 deletion ewave.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,9 @@ def read(
- memmap: if False, reads the whole file into memory at once; if not, returns
a numpy.memmap object using this value as the mode argument. 'c'
corresponds to copy-on-write; use 'r+' to write changes to disk. Be
warned that 'w' modes may corrupt data.
warned that 'w' modes may corrupt data. Memmap may not work with
certain input types (e.g., files in zip archives) and does not currently work
on Windows.
"""
if self.mode == "w":
Expand Down

0 comments on commit 9b1a4ef

Please sign in to comment.