publish: diving into jtag part 3 #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gminn
changed the title
|
@Zamuhrishka Excited to put up the third part of your JTAG series! Could you take a quick look, and let me know if the article looks good from your end? |
gminn
commented
Mar 22, 2024
| @@ -0,0 +1,366 @@ | |||
| --- | |||
There was a problem hiding this comment.
I should have put the line wrapping in a separate commit so changes would be easier to review. A summary of my changes is in the PR description though.
Deploying interrupt with
|
| Latest commit: |
9043f35
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4f3e44b0.interrupt.pages.dev |
| Branch Preview URL: | https://gminn-publish-jtag-part-3.interrupt.pages.dev |
gminn
commented
Mar 22, 2024
noahp
reviewed
Mar 22, 2024
Comment on lines
+191
to
+196
| ```plaintext | ||
| num cell port function | ||
| 405 BC_1, *, CONTROL, | ||
| 404 BC_1, PE2, OUTPUT3, | ||
| 403 BC_4, PE2, INPUT, | ||
| ``` |
There was a problem hiding this comment.
much nicer! could also have been a markdown table i think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is part 3 of the JTAG series! 🎉
A few tweaks for publishing:
img/with
npx prettier --prose-wrap always --write, we shouldrun this precommit!)
Test Plan
Visual check.