Update to Memfault SDK 1.5.0-rc1 #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a branch I pushed to our public SDK github repo. Note that I'll need to rebase the `gminn/lte-metrics` branch of https://github.com/memfault/sdk-nrf.git to pick up a newer upstream `main`, which has an updated sha of their Zephyr fork which includes this commit: zephyrproject-rtos/zephyr@e7bd10a Otherwise the build fails, because our NCS branch is pointing to a commit off upstream main that was randomly off Zephyr working main.
|
The build still fails even with the latest main nrf sdk 😢 They are still on a commit that points to zephyr 3.4.99, which doesn't have the updates because the header changes got added to one of the release candidates, not 3.4.99. You'd think that wouldn't be an issue because our zephyr versioning logic would fix it, but we don't account for the case of changes getting added to release candidates; we assume 3.4.99 is greater than 3.4, and therefore includes the header name change, because it would typically include all the changes for 3.5.0. I have a proposed fix here: https://github.com/memfault/memfault/pull/11865 This made my brain hurt 😅 hopefully I got this straight |
|
#12 had a better version of this change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a branch I pushed to our public SDK github repo.
Note that I'll need to rebase the
gminn/lte-metricsbranch ofhttps://github.com/memfault/sdk-nrf.git to pick up a newer upstream
main, which has an updated sha of their Zephyr fork which includesthis commit:
zephyrproject-rtos/zephyr@e7bd10a
Otherwise the build fails, because our NCS branch is pointing to a
commit off upstream main that was randomly off Zephyr working main.