MFLT-12469 battery soc drop + connection time #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gminn
reviewed
Feb 2, 2024
noahp
force-pushed
the
noahp/mflt-12469
branch
from
4088dfe
to
f103963
Compare
For Device Vitals, populate these metrics. Note that the charger-connect event is not wired up, but that should still enable decent quality soc drop data. Drive by change to include the `.clang-format` file from NCS, so our patches can be formatted in the same way. Manually tested on my thingy91.
noahp
force-pushed
the
noahp/mflt-12469
branch
from
95c8284
to
7f9a057
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Device Vitals, populate these metrics.
Note that the charger-connect event is not wired up, but that should
still enable decent quality soc drop data.
Drive by change to include the
.clang-formatfile from NCS, so ourpatches can be formatted in the same way.
Manually tested on my thingy91.