mpm/jpqr: add ParseIDFromString which is a useful function (#13)

mercari · Apr 16, 2020 · b7d3f8f · b7d3f8f
1 parent 8464d43
commit b7d3f8f
Show file tree

Hide file tree

Showing 2 changed files with 90 additions and 1 deletion.
diff --git a/mpm/jpqr/id.go b/mpm/jpqr/id.go
@@ -57,7 +57,7 @@ func validateIDLength(i *ID) error {
 	return nil
 }
 
-// ParseID validates and parses given string as JPQR-ID.
+// ParseID validates and parses given *mpm.Code as JPQR-ID.
 func ParseID(c *mpm.Code) (*ID, error) {
 	for _, v := range c.MerchantAccountInformation {
 		var id ID
@@ -73,3 +73,12 @@ func ParseID(c *mpm.Code) (*ID, error) {
 	}
 	return nil, errors.New("missing JPQR-ID")
 }
+
+// ParseIDFromString validates and parses given string as JPQR-ID.
+func ParseIDFromString(v string) (*ID, error) {
+	return ParseID(&mpm.Code{
+		MerchantAccountInformation: []tlv.TLV{
+			{Tag: "26", Length: "68", Value: v},
+		},
+	})
+}
diff --git a/mpm/jpqr/id_test.go b/mpm/jpqr/id_test.go
@@ -112,6 +112,86 @@ func TestParseID(t *testing.T) {
 	}
 }
 
+func TestParseIDFromString(t *testing.T) {
+	type args struct {
+		src string
+	}
+	tests := []struct {
+		name    string
+		args    args
+		want    *jpqr.ID
+		wantErr bool
+	}{
+		{
+			args: args{
+				src: "0019jp.or.paymentsjapan011300000000000010204000103060000010406000001",
+			},
+			want: &jpqr.ID{Prefix: "jp.or.paymentsjapan", LV1: "0000000000001", LV2: "0001", LV3: "000001", LV4: "000001"},
+		},
+		{
+			name: "fail: malformed payload",
+			args: args{
+				src: "foobarbaz",
+			},
+			wantErr: true,
+		},
+		{
+			name: "fail: empty src is err",
+			args: args{
+				src: "",
+			},
+			wantErr: true,
+		},
+		{
+			name: "fail: invalid prefix",
+			args: args{
+				src: "0019jp.co.paymentsjapan011300000000000010204000103060000010406000001",
+			},
+			wantErr: true,
+		},
+		{
+			name: "fail: invalid length (LV1)",
+			args: args{
+				src: "0019jp.or.paymentsjapan01130000000000001020300003060000010406000001",
+			},
+			wantErr: true,
+		},
+		{
+			name: "fail: invalid length (LV2)",
+			args: args{
+				src: "0019jp.or.paymentsjapan01130000000000001020300003060000010406000001",
+			},
+			wantErr: true,
+		},
+		{
+			name: "fail: invalid length (LV3)",
+			args: args{
+				src: "0019jp.or.paymentsjapan01130000000000001020400010305000000406000001",
+			},
+			wantErr: true,
+		},
+		{
+			name: "fail: invalid length (LV4)",
+			args: args{
+				src: "0019jp.or.paymentsjapan01130000000000001020400010306000001040500000",
+			},
+			wantErr: true,
+		},
+	}
+	for _, tt := range tests {
+		tt := tt
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := jpqr.ParseIDFromString(tt.args.src)
+			if (err != nil) != tt.wantErr {
+				t.Fatalf("ParseIDFromString() error = %v, wantErr %v", err, tt.wantErr)
+			}
+			if !reflect.DeepEqual(got, tt.want) {
+				t.Errorf("ParseIDFromString() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}
+
 func TestID_String(t *testing.T) {
 	type fields struct {
 		Prefix string