use isSuperset for comparison in isMonitorVPAReady instead of Equals #415
+43
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isMonitorVPAReady now correctly checks that the VPA has recommendations for at least Tortoise defined containers, extra containers doesn't result in a false not ready.
sanposhiho
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isMonitorVPAReady now correctly checks that the VPA has recommendations for at least Tortoise defined containers, extra containers doesn't result in a false not ready.
What this PR does / why we need it:
Changes the comparison in isMonitorVPAReady to behave as expected when there are more containers in the VPA/Pod than defined in the Tortoise object.
Which issue(s) this PR fixes:
Fixes #413
Special notes for your reviewer: