Fix crash caused by sdg not being hashashable #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayoub5
commented
Jul 27, 2023
| @@ -42,8 +42,6 @@ def __hash__(self) -> int: | |||
| result += hash(self.long_name) | |||
| result += hash(self.description) | |||
| result += hash(self.is_visible_raw) | |||
| for sdg in self.sdgs: | |||
| result += hash(sdg) | |||
There was a problem hiding this comment.
@andlaus hash(sdg) caused a crash due to missing __hash__ in the sdg class, fixing it will require a lot of changes
so this hotfix in order to unblock pdx loading
|
looks good, merging... |
|
BTW: what does "hashashable" mean? something involving THC? ;-P |
hashable means primitive type (int, float, str) or class that impliments |
|
that's hashable, sure. but I was wondering about "hashashable" ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.