fix style of last argument of argument lists #341
Conversation
instead of sometimes using a comma for the last item of a list and sometimes not, we now always close the list in the same line. This does not come with any functional changes, but it makes the coding style a bit more consistent and IMO the code is slightly more readable with this style. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Gerrit Ecke <[email protected]>
|
@kayoub5: this is motivated by a comment which you made a while ago :) |
| @@ -118,11 +118,9 @@ def find_named_object(item_list: List[T], name: str) -> T: | |||
| byte_position=0, | |||
| coded_value=FLIC_FLAC_SID, | |||
| bit_position=None, | |||
| sdgs=[], | |||
There was a problem hiding this comment.
keep the comma always, it makes reading diffs easier
There was a problem hiding this comment.
automating the implementation of this is pretty difficult, because for trivial stuff like f(x) we probably don't want the trailing comma. (and I really don't want to do this fully manually.) That said, I'm also happy to close this PR unmerged and keep the current state of the art...
There was a problem hiding this comment.
The idea is if the list or function arguments are multi-line, a trailing comma helps better with diffs
A trailing comma is not needed for a one line list
There was a problem hiding this comment.
yeah. I agree that it makes sense, but my point was that writing a script for "semi-automatic" refactoring for this style is pretty hard... (for the current PR I could basically get away with a bit of regex replacement magic, but I don't see a way to get around a "bracket+string" parser if I have to count the number of arguments, etc.)
There was a problem hiding this comment.
under these constraints, shall we close or merge?
instead of sometimes using a comma for the last item of a list and sometimes not, we now always close lists of items immediately. This does not come with any functional changes, but it makes the coding style a bit more consistent and IMO the code is slightly more readable with this style.
Andreas Lauser <[email protected]>, on behalf of MBition GmbH.
Provider Information