Truncate the mask when its length is greater than the length of the internal value #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayoub5
approved these changes
Sep 18, 2024
|
thanks! |
|
@nada-ben-ali: I've added you to the maintainers of the repository. Welcome to the club :) |
|
@andlaus Thank you a lot 🤩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to avoid the “OverflowError: int too big to convert” exception when the length of the mask exceeds the length of the internal value. The issue arises when self.bit_mask contains more bits than can be represented by the given number of bytes (sz), leading to an overflow during the conversion to bytes.
By ensuring that the mask is truncated or adjusted to fit within the appropriate byte size, this approach prevents the exception and allows for safe conversion of the mask, and then prevents unexpected crashes due to overflow.
odxtools version: 8.0.5