Improve the parameter_info() function
#348
Conversation
It now knows about system parameters, `SCALE-LINEAR`, `RAT-FUNC` and `SCALE-RAT-FUNC` and `COMPU-CODE` parameters. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Gerrit Ecke <[email protected]>
andlaus
force-pushed
the
improve_parameter_info
branch
from
a4bb912
to
6503e1c
Compare
| return "<unknown type>" | ||
|
|
||
|
|
||
| def _get_linear_segment_info(segment: LinearSegment) -> str: |
There was a problem hiding this comment.
I have a feeling this should be in the __str__ or __repr__ function of LinearSegment
There was a problem hiding this comment.
I don't think that LinearSegment and RationalSegment objects should be printed under normal circumstances, and if they are, usually something like the slope and the offset are desired? (IMO this is not the case in the context of parameter_info() were we are only interested in what ranges can be specified for a given parameter. Opinions welcome...)
There was a problem hiding this comment.
The idea is that the function that describes the object is human readable way, should be in the object itself, even if it's just for the sake of showing better values in the debugger.
There was a problem hiding this comment.
yes. my main point is that in most contexts other than parameter_info(), this probably requires a bit more information than just the domain where the segment is defined (i.e., some info what the segment does)...
this method returns what the `DataType` object would be on the python side. as [at]kayoub5 points out, this is probably what is wanted 90% of the time such an object is printed. Also, this can now be directly used by `parameter_info()`. thanks to [at]kayoub5 for the insistence. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Gerrit Ecke <[email protected]>
thanks to [at]kayoub5 for pointing this out. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Gerrit Ecke <[email protected]>
andlaus
force-pushed
the
improve_parameter_info
branch
from
4a9f43a
to
b9b0c55
Compare
It now knows about system parameters,
SCALE-LINEAR,RAT-FUNCandSCALE-RAT-FUNCandCOMPU-CODEparameters. Also, the code is a bit easier to read and contains a few smaller drive-by fixes.this is a spin-off of #347 and thus build on top of that PR.
Andreas Lauser <[email protected]>, on behalf of MBition GmbH.
Provider Information