change list command output from tabulate to rich tables #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kayoub5
requested changes
Nov 3, 2024
| @@ -4,7 +4,8 @@ | |||
| from typing import Any, Callable, Dict, List, Optional, Union | |||
|
|
|||
| import markdownify | |||
| from tabulate import tabulate # TODO: switch to rich tables | |||
There was a problem hiding this comment.
tabulate dependency not removed from pyproject.toml
There was a problem hiding this comment.
I cannot remove tabulate from dependency some other files are using it. This PR was specifically for list command output. I can update rest as well and then remove it.
andlaus
reviewed
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue resolved: I have updated the list bash output by replacing the tabulate table with rich tables.
File updated: cli/_print_utils.py
The output looks like this:
