forked from indexmap-rs/indexmap
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from bluss:master #5
Open
pull
wants to merge
326
commits into
mesalock-linux:master
Choose a base branch
from
indexmap-rs:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare for indexmap 2.0
Documentation assertion in erase_index function
Add dynamically-sized slices of maps and sets
Implement `From` between `IndexedEntry` and `OccupiedEntry`
Add a few nods to `BTreeMap`/`Set`
The only difference compared to using `shift_insert` is when the binary-searched key isn't *actually* new to the map, just not found in properly sorted order. In this case we can't guarantee a sorted result either, but it will at least behave better about the new position, especially if that's the end.
Assert bounds in `shift_insert` and add `insert_before`
Release 2.5.0
This is a targeted test to make sure we cover all the heuristic edge cases in `erase_indices`, used by `drain` and other methods. I found a failure from `cargo mutants` where we still passed tests after `erase_indices_sweep` was replaced with an empty body. I was concerned because that function contains `unsafe` code, so we *really* need it tested. It turns out that we do *sometimes* hit that in `quickcheck` tests, but might miss that if we're randomly unlucky, so this PR adds a new test that will hit all the edge cases every time.
Test the various heuristics of `erase_indices`
Derive `Clone` for `{map,set}::IntoIter`
docs: Improve doc formatting with backticks
It did already panic as expected, but with a confusing message if the `to` index was out of bounds. Now we have a direct bounds check for that at the start, just as there already was for the `from` index.
Add an explicit bounds check in `move_index`
Use `hashbrown::HashTable` instead of `RawTable`
Release 2.6.0
Use rayon-1.9.0's `collect_vec_list`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )