Raise exception if invalid values are given to 'clone-recursive'

mesonbuild · Oct 30, 2024 · 29710ea · 29710ea
1 parent c2e120b
commit 29710ea
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/mesonbuild/wrap/wrap.py b/mesonbuild/wrap/wrap.py
@@ -622,9 +622,15 @@ def _get_git(self, packagename: str) -> None:
                     args += ['--branch', revno]
                 args += [self.wrap.get('url'), self.directory]
                 verbose_git(args, self.subdir_root, check=True)
-        if self.wrap.values.get('clone-recursive', '').lower() == 'true':
-            verbose_git(['submodule', 'update', '--init', '--checkout', '--recursive', *depth_option],
-                        self.dirname, check=True)
+
+        clone_recursive_val = self.wrap.values.get('clone-recursive')
+        if clone_recursive_val is not None:
+            clone_recursive_val = self.wrap.values.get('clone-recursive', '').lower()
+            if clone_recursive_val == 'true':
+                verbose_git(['submodule', 'update', '--init', '--checkout', '--recursive', *depth_option],
+                            self.dirname, check=True)
+            elif clone_recursive_val != 'false':
+                raise WrapException('clone-recursive: invalid value (use \'true\' or \'false\')')
         push_url = self.wrap.values.get('push-url')
         if push_url:
             verbose_git(['remote', 'set-url', '--push', 'origin', push_url], self.dirname, check=True)