cargo: Run build.rs to get extra --cfg args #13779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a global Cargo interpreter state that keeps track of enabled features on each crate. Before generating AST of a Cargo subproject, it downloads every sub-subproject and resolves the set of features enabled on each of them recursively. When it later generates AST for one its dependencies, its set of features and dependencies is already determined.
The library name defaults to its package name, but it can be different. For example: - package name: cairo-sys-rs - library name: cairo-sys - dependency name: ffi
In the case the main project has a .wrap file for a cargo subproject, that subproject's Cargo.lock must be loaded before we can recursively fetch all its dependencies.
This returns --target value from rustc command line, or the native target.
xclaesse
force-pushed
the
cargo-build-rs
branch
from
f169b16
to
ed2e434
Compare
xclaesse
force-pushed
the
cargo-build-rs
branch
from
ed2e434
to
db26175
Compare
eli-schwartz
requested changes
Oct 11, 2024
There was a problem hiding this comment.
As I've said before, we should not be doing this. At all. We cannot reliably run build.rs, the garden path of cases that actually (and really slowly) manage to successfully run also do not need to be a build.rs so using meson/meson.build will be a superior experience, etc.
The system-deps patch does look quite nice though :) and it's very good that we can do it without build.rs.
There was a problem hiding this comment.
Basically, what you actually want is rust-lang/cargo#7178 and to have people opt into that via run_command(), which we already document as an escape hatch to do whatever you want as long as meson doesn't take responsibility for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #12952.