Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Regex should account for tag version string correctly. #12

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

kaiwalyajoshi
Copy link

@kaiwalyajoshi kaiwalyajoshi commented Mar 4, 2024

Description

Release Workflow regex currently doesn't match d2iq tags. This can be verified:

Checklist

  • tested locally
  • updated any relevant dependencies
  • updated any relevant documentation or examples

API Changes

Are there API changes?

  • Yes
  • No

If yes, please fill in the below

  1. Updated conversions?
    • Yes
    • No
    • N/A
  2. Updated CRDs?
    • Yes
    • No
    • N/A
  3. Updated infrastructure-components.yaml?
    • Yes
    • No
    • N/A
  4. Updated ./examples/capi-quickstart.yaml?
    • Yes
    • No
    • N/A
  5. Updated necessary files under ./infrastructure-vcd/v1.0.0/?
    • Yes
    • No
    • N/A

Issue

If applicable, please reference the relevant issue

Fixes #

@kaiwalyajoshi kaiwalyajoshi merged commit 652de88 into d2iq/main Mar 4, 2024
1 check passed
@@ -2,7 +2,7 @@ name: Release
on:
push:
tags:
- v*-d2iq.*
- v.*-d2iq.*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a regex, this is a glob (see https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushbranchestagsbranches-ignoretags-ignore The branches, branches-ignore, tags, and tags-ignore keywords accept glob patterns that use characters like *, **, +, ?, ! and others to match more than one branch or tag name and https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet) - I don't think this change is correct.

@kaiwalyajoshi kaiwalyajoshi mentioned this pull request Mar 7, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants