Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 chore: cherry pick changes from 1.4.4 to 1.5.1 #19

Merged
merged 5 commits into from
Sep 8, 2023

Conversation

cbuto
Copy link

@cbuto cbuto commented Sep 6, 2023

What this PR does / why we need it:
Following what was done in #18. This is one part of https://d2iq.atlassian.net/browse/D2IQ-98202.

I cherry-picked the changes applied on top of 1.4.4 kubernetes-sigs/cluster-api@v1.4.4...mesosphere:cluster-api:v1.4.4-d2iq.0.

dropped the following commits:
727f1c2 - another fix for this was merged upstream in v1.5.0
7f84879 - this was also merged upstream in v1.5.0

Here is the migration guide: https://main.cluster-api.sigs.k8s.io/developer/providers/migrations/v1.4-to-v1.5

  • We need to remove the LazyRestMapper feature gate
  • It also looks like we reference v1alpha3 in a few places

Manually tested by:

  • Created a bootstrap cluster
  • built the images locally and updated the capi, kubeadm contollers, and capd deployments
    • I also had to remove the LazyRestMapper feature gate
  • created three docker clusters

The first test I ran, the capi-kubeadm-bootstrap-controller-manager pod was OOMKilled once after creating a cluster. Subsequent tests with 3 clusters in a row didn't hit this.

@cbuto cbuto self-assigned this Sep 6, 2023
@cbuto cbuto changed the title chore: cherry pick changes from 1.4.4 to 1.5.1 🌱 chore: cherry pick changes from 1.4.4 to 1.5.1 Sep 6, 2023
@cbuto cbuto marked this pull request as ready for review September 7, 2023 15:20
Copy link
Collaborator

@dkoshkin dkoshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Im excited for that list of commits to be going down 🥳

I also had to remove the LazyRestMapper feature gate

Is this s FF that was removed upstream?

@cbuto
Copy link
Author

cbuto commented Sep 8, 2023

Is this s FF that was removed upstream?

@dkoshkin yup, it looks like we disabled it previously LazyRestmapper=false for some reason.

from https://main.cluster-api.sigs.k8s.io/developer/providers/migrations/v1.4-to-v1.5#removals

The lazy restmapper feature gate was removed in controller-runtime and lazy restmapper is now the default restmapper. Accordingly the EXP_LAZY_RESTMAPPER feature gate was removed in Cluster API.

@dkoshkin dkoshkin merged commit 72247b1 into d2iq/release-1.5.1 Sep 8, 2023
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants