Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add multi-cluster metrics and alerting post #86

Merged
merged 11 commits into from
Sep 6, 2023
Merged

feat: add multi-cluster metrics and alerting post #86

merged 11 commits into from
Sep 6, 2023

Conversation

mhrabovcin
Copy link
Contributor

No description provided.

@mhrabovcin mhrabovcin requested review from tillt and a team as code owners August 31, 2023 10:54
@netlify
Copy link

netlify bot commented Aug 31, 2023 •
edited
Loading

✅ Deploy Preview for d2iq-engineering ready!

Name Link
🔨 Latest commit af2bfde
🔍 Latest deploy log https://app.netlify.com/sites/d2iq-engineering/deploys/64f78b556ecb6e0008bc9e76
😎 Deploy Preview https://deploy-preview-86--d2iq-engineering.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99
Accessibility: 94
Best Practices: 92
SEO: 90
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@mhrabovcin mhrabovcin self-assigned this Aug 31, 2023
@tillt
Copy link
Contributor

tillt commented Aug 31, 2023

Needs an author image - similar to what Casey did here; https://github.com/mesosphere/d2iq-engineering-blog/pull/85/files

tillt
tillt reviewed Sep 5, 2023
View reviewed changes
Copy link
Contributor

@tillt tillt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff - love it - shall convince more users to license DKP!

content/posts/multi-cluster-monitoring-and-alerting/index.md Outdated Show resolved Hide resolved
content/posts/multi-cluster-monitoring-and-alerting/index.md Show resolved Hide resolved
content/posts/multi-cluster-monitoring-and-alerting/index.md Outdated Show resolved Hide resolved
content/posts/multi-cluster-monitoring-and-alerting/index.md Outdated Show resolved Hide resolved
content/posts/multi-cluster-monitoring-and-alerting/index.md Outdated Show resolved Hide resolved
content/posts/multi-cluster-monitoring-and-alerting/index.md Outdated Show resolved Hide resolved
content/posts/multi-cluster-monitoring-and-alerting/index.md Outdated Show resolved Hide resolved
content/posts/multi-cluster-monitoring-and-alerting/index.md Outdated Show resolved Hide resolved
content/posts/multi-cluster-monitoring-and-alerting/index.md Outdated Show resolved Hide resolved
content/posts/multi-cluster-monitoring-and-alerting/index.md Outdated Show resolved Hide resolved
mhrabovcin and others added 2 commits September 5, 2023 19:21
@mhrabovcin @tillt
chore: pr feedback - till
4b7fc0f 
Co-authored-by: Till Toenshoff <[email protected]>
Signed-off-by: Martin Hrabovcin <[email protected]>
@mhrabovcin @tillt
chore: pr feedback - till
c0a686a 
Co-authored-by: Till Toenshoff <[email protected]>
Signed-off-by: Martin Hrabovcin <[email protected]>
tillt
tillt approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@tillt tillt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last change from my side -- suggesting to apply that tomorrow morning.

content/posts/multi-cluster-monitoring-and-alerting/index.md Outdated Show resolved Hide resolved
@mhrabovcin @tillt
chore: fix post date
b453be6 
Co-authored-by: Till Toenshoff <[email protected]>
Signed-off-by: Martin Hrabovcin <[email protected]>
msdolbey
msdolbey approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@msdolbey msdolbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some small commit suggestions, mostly capitalization and stuff like that.
This was a super useful post, Thanks @mhrabovcin !

👍
Yes

mhrabovcin and others added 4 commits September 5, 2023 21:57
@mhrabovcin @msdolbey
chore: pr feedback - casie, matt
10dbc0f 
Co-authored-by: Casie Oxford <[email protected]>
Co-authored-by: msdolbey <[email protected]>
Signed-off-by: Martin Hrabovcin <[email protected]>
@mhrabovcin @msdolbey
chore: pr feedback - casie, matt
33e7f03 
Co-authored-by: Casie Oxford <[email protected]>
Co-authored-by: msdolbey <[email protected]>
Signed-off-by: Martin Hrabovcin <[email protected]>
@mhrabovcin
chore: pr feedback - casie, matt
42e8c0a 
Co-authored-by: Casie Oxford <[email protected]>
Signed-off-by: Martin Hrabovcin <[email protected]>
@mhrabovcin
chore: pr feedback
af2bfde
@tillt tillt merged commit 89aab0d into main Sep 6, 2023
6 checks passed
@tillt tillt deleted the mh/dkp-metrics branch September 6, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmastr cmastr cmastr approved these changes

@msdolbey msdolbey msdolbey approved these changes

@tillt tillt tillt approved these changes

Assignees

@mhrabovcin mhrabovcin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhrabovcin @tillt @msdolbey @cmastr