Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added steps for cluster move operation and added a reference to the new capi in-cluster-ippool solution #98

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

arbhoj
Copy link
Contributor

@arbhoj arbhoj commented Nov 2, 2023

Added steps for cluster move operation and added a reference to the new capi in-cluster-ippool solution.

@arbhoj arbhoj requested review from tillt and a team as code owners November 2, 2023 21:34
Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for d2iq-engineering ready!

Name Link
🔨 Latest commit 2f1335b
🔍 Latest deploy log https://app.netlify.com/sites/d2iq-engineering/deploys/654d7ac5bbd85e0008dec9c8
😎 Deploy Preview https://deploy-preview-98--d2iq-engineering.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97
Accessibility: 94
Best Practices: 92
SEO: 90
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@msdolbey
Copy link
Contributor

msdolbey commented Nov 3, 2023

@arbhoj - I made some grammar changes and just pushed them - if you need any other changes, you'll want to pull.

Copy link
Contributor

@msdolbey msdolbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I made a couple small nits - other than that, looks good to me:

Mooooooving operations

Copy link
Contributor Author

@arbhoj arbhoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@msdolbey msdolbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tillt tillt enabled auto-merge November 9, 2023 22:40
@tillt tillt disabled auto-merge November 9, 2023 22:40
Copy link
Contributor Author

@arbhoj arbhoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tillt tillt force-pushed the node-ipam-update branch 3 times, most recently from f7ac223 to 799db2e Compare November 10, 2023 00:32
arvindbhoj and others added 3 commits November 10, 2023 01:34
and not content related necessarily
just solely grammatical and whatnot
@tillt tillt merged commit 6d4b3b3 into main Nov 10, 2023
7 checks passed
@tillt tillt deleted the node-ipam-update branch November 10, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants