Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide crane warnings by default #507

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

jimmidyson
Copy link
Contributor

Warnings such as the following cause confusion for no reason - everything is working as expected:

2023/09/13 17:32:25 retrying without mount: POST
UNAUTHORIZED: project istio not found: project istio not found

Warnings such as the following cause confusion for no reason - everything is working as expected:

```
2023/09/13 17:32:25 retrying without mount: POST
UNAUTHORIZED: project istio not found: project istio not found
```
@github-actions
Copy link
Contributor

Unit test results

100 tests   100 ✔️  0s ⏱️
  24 suites      0 💤
    1 files        0

Results for commit 8bf4961.

@jimmidyson jimmidyson enabled auto-merge (squash) September 13, 2023 16:49
@github-actions
Copy link
Contributor

e2e test results

32 tests   32 ✔️  1m 42s ⏱️
  2 suites    0 💤
  1 files      0

Results for commit 8bf4961.

Copy link
Contributor

@tillt tillt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jimmidyson jimmidyson merged commit 929c914 into main Sep 15, 2023
12 checks passed
@jimmidyson jimmidyson deleted the jimmi/hide-crane-warnings branch September 15, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants