Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use self-hosted fonts from staticbrainz.org #1881

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

amCap1712
Copy link
Member

@amCap1712 amCap1712 commented Feb 25, 2022

Keeping in mind ORG-51, we decided to self host google fonts on staticbrainz.org. The fonts themselves are now available on SB but we also need to modiffy the css @import urls and link to fonts.google.com.

TODO

  • staticbrainz.org currently does not add CORS headers for localhost so the fonts cannot be loaded in dev setup. This is not good so we should wait to fix that before merging.
  • Check there are no other usages in LB which need to be updated.
  • Check fonts work properly across browsers and versions.

@alastair
Copy link
Collaborator

As we mentioned in IRC, musicbrainz hosts static assets from the dev server during local development. We could modify our get_static_path to handle both of these cases so that we don't need CORS headers for localhost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants