Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SoundCloud Playlist Export & Import functionalities #2965

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

SoundCloud Playlist Export & Import functionalities #2965

wants to merge 11 commits into from

Conversation

rimma-kubanova
Copy link
Contributor

@rimma-kubanova rimma-kubanova commented Aug 22, 2024 •
edited
Loading

Implemented export and import features for SoundCloud

IMPORT:

  • Added modal for SoundCloudPlaylistImport
  • Added endpoints for SoundCloud Playlist import and playlist tracks import

EXPORT:

  • Added troi call for SoundCloud export
  • Added endpoint for SoundCloud export on back
  • Added button for SoundCloud export on front
  • Added endpoint for exporting jspf playlist to SoundCloud

@pep8speaks
Copy link

pep8speaks commented Aug 22, 2024 •
edited
Loading

Hello @rimma-kubanova! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-09-02 10:41:57 UTC

@anshg1214 anshg1214 self-requested a review August 28, 2024 17:35
anshg1214
anshg1214 requested changes Aug 30, 2024
View reviewed changes
Copy link
Member

@anshg1214 anshg1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks great!

I'm not able to import the playlist from soundcloud. The error message says

UnboundLocalError: cannot access local variable 'name' where it is not associated with a value

image

listenbrainz/metadata_cache/soundcloud/client.py Outdated Show resolved Hide resolved
listenbrainz/webserver/views/playlist_api.py Outdated Show resolved Hide resolved
frontend/js/src/user/playlists/components/ImportSoundCloudPlaylistModal.tsx Outdated Show resolved Hide resolved
frontend/js/src/user/playlists/components/ImportSoundCloudPlaylistModal.tsx Outdated Show resolved Hide resolved
@rimma-kubanova rimma-kubanova mentioned this pull request Sep 2, 2024
Merged
@rimma-kubanova
Copy link
Contributor Author

The PR looks great!

I'm not able to import the playlist from soundcloud. The error message says

UnboundLocalError: cannot access local variable 'name' where it is not associated with a value

image

Hi @anshg1214, thanks for catching that! It looks like I updated the code for export but overlooked the import adjustments. 😅 I’ve fixed it now in this PR.

I'm also working on the other requested changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshg1214 anshg1214 anshg1214 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rimma-kubanova @pep8speaks @anshg1214