Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exporting playlists to Apple functionality #2968

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rimma-kubanova
Copy link
Contributor

Export to Apple Music

Frontend:

  • Added an "Export to Apple Music" button on the user interface
  • Added API Callbacks in APIService

Backend:

  • Added export_to_apple_music to export_playlist endpoint. export_to_apple_music calls troi
  • Added export JSPF playlist to Apple Music

@pep8speaks
Copy link

pep8speaks commented Aug 28, 2024

Hello @rimma-kubanova! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1120:1: E302 expected 2 blank lines, found 1
Line 1156:131: E501 line too long (135 > 130 characters)

Line 886:131: E501 line too long (146 > 130 characters)
Line 1047:15: E225 missing whitespace around operator

Comment last updated at 2024-10-22 08:23:09 UTC

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whose review you were waiting for, but I think it's been long enough of a wait for me to jump in :)
Please excuse if I am unaware of some aspects of your project and some of the suggestions below are incorrect.

Overall looks good, some details need to be addressed before I can properly test the feature.

frontend/js/src/playlists/components/PlaylistMenu.tsx Outdated Show resolved Hide resolved
listenbrainz/webserver/views/playlist_api.py Outdated Show resolved Hide resolved
listenbrainz/webserver/views/playlist_api.py Outdated Show resolved Hide resolved
listenbrainz/webserver/views/playlist_api.py Outdated Show resolved Hide resolved
Comment on lines 1043 to 1044
elif service == "soundcloud":
apple_service = AppleService()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look right. Should it be this?

Suggested change
elif service == "soundcloud":
apple_service = AppleService()
elif service == "apple_music":
apple_service = AppleService()

@rimma-kubanova
Copy link
Contributor Author

@MonkeyDo Hi! Thanks for your review!
I’ve made the necessary fixes and also added a unit test case for Apple as well. Sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants