Add an endpoint to get all donors with flairs #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @amCap1712! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-10-24 17:21:23 UTC |
mayhem
requested changes
Oct 24, 2024
| @crossdomain | ||
| @ratelimit() | ||
| def all_flairs(): | ||
| """ Get flairs (including expired ones) for all users """ |
There was a problem hiding this comment.
I think we need more details in this endpoint documentation. What does this endpoint return? Does the caller need to care about expired flairs?
| @@ -27,6 +27,8 @@ def update_flair(): | |||
| if "flair" not in request.json: | |||
| raise APIBadRequest("Missing flair") | |||
|
|
|||
| # todo: add flair validation | |||
There was a problem hiding this comment.
Does this need to be done now or add a ticket?
There was a problem hiding this comment.
this needs to be done (if at all) after the structure of the flairs has been decided.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.