Force size of icons for Youtube #3009
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youtube forces us to follow their branding guidelines to the letter, so we need to force a minimum height of 20px for the icon path inside the svg. For the Brainzplayer UI I made all icons bigger, for the artist page just the youtube icon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Youtube forces us to follow their branding guidelines to the letter, so we need to force a minimum height of 20px for the icon path inside the svg.
They reported two "infractions" in the BrainzPlayer UI and on the artist/album page header icons.
For the Brainzplayer UI I made all icons bigger, for the artist page just the youtube icon.