Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Submit ISRC plugin to match the revised format of call to MBAPIHelper class in Picard #356

Merged
merged 2 commits into from
Jul 29, 2023

Conversation

rdswift
Copy link
Contributor

@rdswift rdswift commented Jul 28, 2023

Changes in Picard 2.9 to the way the path is passed to the MBAPIHelper class post method (metabrainz/picard#2225) broke the Submit ISRC plugin. This PR revises the plugin to use the new format for the path argument to the method.

Question: Should the PLUGIN_API_VERSIONS list be reduced to only '2.9' because I'm not sure that it will work with prior versions of Picard?

@phw
Copy link
Member

phw commented Jul 28, 2023

We missed that use, really thought we would not break any of the existing plugins.

Should the PLUGIN_API_VERSIONS list be reduced to only '2.9' because I'm not sure that it will work with prior versions of Picard?

Yes, I would suggest to do that. The alternative would be to check the Picard version and use the old format for the path for older versions.

@rdswift
Copy link
Contributor Author

rdswift commented Jul 28, 2023

We missed that use, really thought we would not break any of the existing plugins.

It looks like it also breaks the Submit Folksonomy Tags plugin. I can open a PR for that one as well.

Should the PLUGIN_API_VERSIONS list be reduced to only '2.9' because I'm not sure that it will work with prior versions of Picard?

Yes, I would suggest to do that. The alternative would be to check the Picard version and use the old format for the path for older versions.

I'll maybe check the Picard version as you suggested. That way it will still work on older installations.

@phw phw merged commit 9509b80 into metabrainz:2.0 Jul 29, 2023
6 checks passed
@rdswift rdswift deleted the submit_isrc_plugin_repair branch July 29, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants