Submit Folksonomy Tags: Refactor code + clean up imports #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viktini
commented
Aug 9, 2023
| """ | ||
| Processes a track list to just a file list, checking if | ||
| the MBID is in the banned list and if alert_multiple_mbids | ||
| needs to be checked. | ||
| """ | ||
| global inconsistent_detected, alert_multiple_mbids |
There was a problem hiding this comment.
whoops, removed the wrong one. 😐 fixed it though
|
Closing as I'm not 100% satisfied with how it was done, I'll keep the old code for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, thanks to @rdswift for updating SFT to work with version 2.9's API. I was recovering from illness when that PR was merged, so I wouldn't have been able to deal with it.
Now, a while back I said I would refactor the code, and this is essentially part of that. There might be some more refactoring required, but I think this should be good enough right now to make the code easier to deal with. I've also split the network function and submit handling off to separate files.
LMK if there are any problems!