Deezerart: Use astrcmp and make matching threshold configurable #360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deezerart plugin used Python's difflib for string similarity comparison. This has some problems:
difflib ist not part of the Picard binary packages for macOS and Windows, as the bundled Python only includes those modules actually used
The
SequenceMatcher.quick_ratio
only compares length and characters, not sequences (which means order of characters does not matter). See for example:Use Picard's
astrcmp
function instead. A value of 0.6 seemed sensible in my tests. But a configuration option was added so users can tweak the threshold if they get bad results.