New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update acousticbrainz plugins to correctly use a 1s rate limit. #362

Merged

phw merged 2 commits into metabrainz:2.0 from Sophist-UK:patch-21

Oct 24, 2023

Contributor

Sophist-UK commented Oct 24, 2023

Actual acousticbrainz rate limit is 10 requests every 10s

Sophist-UK added 2 commits

October 24, 2023 17:41


          Update acousticbrainz_tonal-rhythm.py to use 1s rate limit

954d039


          Update acousticbrainz/__init__.py to use 1s rate limit.

1923b3f

phw approved these changes

View reviewed changes

Member

phw left a comment

Thanks. The history is interesting. Originally there was a 50ms delay. Got increased in both plugins, one to 100, one to 250ms.

I don't know the AB side, but maybe the rate limiting was increased after deprecation of the service?

Anyway, let's merge this

phw merged commit ed40948 into metabrainz:2.0

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet