add Add to Collection plugin #373
Conversation
dvirtz
force-pushed
the
add-to-collection
branch
from
f2dd337
to
ae67dbd
Compare
There was a problem hiding this comment.
Thanks a lot for this. This is definitely useful and it is looking good. LGTM
Overall this is some functionality that eventually should end up in Picard at some point. But at this moment I think having it as a plugin and letting that mature first is a good move.
For a future idea I think it would be cool if one could define some conditions to have saved releases end up in different collections based on some criteria. E.g. I keep my physical releases in a separate collection from the downloads.
| module = obj.__module__ | ||
| obj.__module__ = ".".join(module.split(".")[:-1]) | ||
| yield | ||
| obj.__module__ = module |
There was a problem hiding this comment.
I guess it's fine and I understand why you wanted to split this appart as you did. But it also feels a bit like over engineering for this plugin, to be honest.
Anyway, I'm fine keeping this.
There was a problem hiding this comment.
I hope this limitation can be lift off in V3
There was a problem hiding this comment.
Yes, I will look into this when I get back to the reworked plugin handling
This plugin adds any saved release to one of the user collections