Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deezerart: fixed crash if artist similarity is below threshold #380

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

phw
Copy link
Member

@phw phw commented Jul 12, 2024

If the artist similarity is below the configured threshold the plugin crashed with:

Traceback (most recent call last):
  File "/tmp/.mount_MusicBdwLOgu/usr/conda/lib/python3.12/site-packages/picard/webservice/__init__.py", line 593, in _process_reply
    self._handle_reply(reply, request)
  File "/tmp/.mount_MusicBdwLOgu/usr/conda/lib/python3.12/site-packages/picard/webservice/__init__.py", line 581, in _handle_reply
    handler(bytes(reply.readAll()), reply, error)
  File "/home/phw/Applications/MusicBrainz-Picard-daily-x86_64.AppImage.config/MusicBrainz/Picard/plugins/deezerart/deezer/client.py", line 57, in handler
    callback(result, error)
  File "/home/phw/Applications/MusicBrainz-Picard-daily-x86_64.AppImage.config/MusicBrainz/Picard/plugins/deezerart/__init__.py", line 133, in _queue_from_search
    self.log_debug('artist similarity below threshold: %r ~ %r', artist, result.artist.title)
                                                                         ^^^^^^^^^^^^^^^^^^^
AttributeError: 'Artist' object has no attribute 'title'
Aborted (core dumped)

@phw phw merged commit 1fd3cfe into metabrainz:2.0 Jul 12, 2024
6 of 7 checks passed
@phw phw deleted the deezerart-crash-fix branch July 12, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant