update documentation

[Dami-18]

Fixes #11

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
heimdall	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 28, 2024 0:15am

[Dami-18]

@chirag-ghosh @rohan-b-84 review please

[rohan-b-84]

Can you also update the frontend readme file as well ?
Right now you've mentioned to run npm run dev in base directory, when it should be inside ./frontend

Also, suggest using pnpm instead of npm

Documenting doesn't only mean updating docs on how to run the server, you'll have to mention what the application does, and how its supposed to be used

[rohan-b-84]

@Dami-18 have you added a way to display cooldown timer for resend OTP ?
I don't see those changes anywhere

[Dami-18]

@Dami-18 have you added a way to display cooldown timer for resend OTP ? I don't see those changes anywhere

I haven't added any timer. Only displaying the message that please wait for 60s as it was already set in the backend

[Dami-18]

Should I add timer also?

[proffapt]

It is always recommended to have separation of concerns in PRs as well. Solving two separate issues in a PR doesn't help in better resolution. Create two separate PRs for each issue.

[proffapt]

Also this is what we have planned as a solution to this:

• use requests the OTP
• in frontend a time starts in content of the request otp button
• the button is disabled till the timer hits 0
• a text appears resend otp and the button is now clickable

[Dami-18]

Why am I getting "No JWT session token found" in /validate-jwt even after I verified using otp?

[chirag-ghosh]

The cookie we are using is a secure cookie. It is only sent by the browser for HTTPS requests. Since you are using localhost which is HTTP, the browser is not sending the cookie in the first place.

[Dami-18]

@proffapt can you once explain how does heimdall work internally? So I can do the required changes in documentation and this pr can be closed