Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the a tag from the block to inline in HTMLParser | Fixes #371 #372

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

matuzalemsteles
Copy link
Contributor

Copy link

@brunobasto brunobasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but wondering if we can run any kind of tests with this change applied and see if anything in Metal breaks.

@yuchi
Copy link
Contributor

yuchi commented Apr 24, 2018

Please pay attention that a is a special element that can contain both block and inline elements.

I didn't look at the source but looks like you are inferring the child type of an element based on what kind of element it is, while the spec is a little bit more complex AFAIK.

@matuzalemsteles
Copy link
Contributor Author

@brunobasto, I'm adding some cases to the tests that it broke before when it was in the Block elements list and adding some cases of using it as block and inline.

hey @yuchi, thanks for your concerns, as the current parser it follows this line of inferring the elements in block and inline ... I am just adding one more exception to a element since we can do it from block or inline. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants