Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Disable deep image inspection for e2e #2122

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Dec 12, 2024

This commit:

  • disables Ironic's deep image inspection feature for e2e tests as this feature is incompatible with live-iso e2e tests.

This commit:
  - disables Ironic's deep image inspection feature for e2e tests as this
    feature is incompatible with live-iso e2e tests.

Signed-off-by: Adam Rozman <[email protected]>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 12, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Dec 12, 2024

Related ironic-image change that is required to be merged for this PR to work: metal3-io/ironic-image#603 .
Related BMO Issue: #2110

@Rozzii
Copy link
Member Author

Rozzii commented Dec 12, 2024

/cc @kashifest @tuminoid

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2024
@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@metal3-io-bot metal3-io-bot merged commit c91cfcc into metal3-io:main Dec 16, 2024
15 checks passed
@metal3-io-bot metal3-io-bot deleted the disable_deep_img_inspection branch December 16, 2024 14:30
@metal3-io-bot metal3-io-bot added this to the BMO - v0.9 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants