Fix partition num when paths contain directories #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current method of calculating the number of partitions didn't take into account the real size of the files in a directory, it used the size of a directory, i.e. 4k bytes.
drcrallen
suggested changes
Apr 4, 2017
| fs.getFileStatus(p).getLen | ||
| if (fs.getFileStatus(p).isDirectory) { | ||
| var sum = 0l | ||
| val children = fs.listFiles(p, false) |
There was a problem hiding this comment.
Can you scala-fy this? This syntax will be off, but something like:
sum += fs.listFiles(p, false).map(_.getLen).sumThere was a problem hiding this comment.
fs.listFiles returns a RemoteIterator, which isn't a subclass of Iterator and as such, there is no implicit converters towards Scala types. I could do something like Iterator.continually(Try { children.next().getLen }).takeWhile(_.isSuccess).map(_.get).sum, but I'm not sure it's better.
Which one you'd prefer?
There was a problem hiding this comment.
I'd prefer for Hadoop to do things in a way that is compatible with Scala :-P
barring that, please add a comment to why the manual iteration is needed.
|
Sure, I'll add unittests ASAP (it might be not too soon though, sorry) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96