smol fix for process_remove_member.rs #1166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plz sers, I will earn so much of my hydra wasted efforts back if we can fix the remove Member ix. expected behavior: feed it a member (which is seeded as mint of membership voucher) and a destination (native account) and it works actual behavior: it does a check to see if member is owned by spl token, errors if so with "InvalidCloseAccountDestination. Error Number: 6024. Error Message: Sending Sol to a SPL token destination will render the sol unusable." fix: this check is meant for the destination, to see if it is a native account. do a switcheroo and the checks should pass.
it's actually better like this, tbf.
|
edits, yes I'm doon this in the browser: check if destination not owned by system program, if not, error with more appropriate error. |
|
hi :) @blockiosaurus |
|
I'll personally be at least 42 sol up when this gets merged 🙏🏻 |
|
Can you fix the formatting so the CI passes? |
blockiosaurus
requested changes
May 15, 2024
|
roger, wip |
|
alright @blockiosaurus I have no idea how to see which ci are failing or why |
staccDOTsol
requested review from
shotgunofdeath and
danenbm
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plz sers, I will earn so much of my hydra wasted efforts back if we can fix the remove Member ix.
expected behavior: feed it a member (which is seeded as mint of membership voucher) and a destination (native account) and it works
actual behavior: it does a check to see if member is owned by spl token, errors if so with "InvalidCloseAccountDestination. Error Number: 6024. Error Message: Sending Sol to a SPL token destination will render the sol unusable."
fix: this check is meant for the destination, to see if it is a native account. do a switcheroo and the checks should pass.