Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow the seller to cancel its bids from its own listing #853

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

akkoucai
Copy link

I added the condition buyer_price == AUCTIONEER_BUYER_PRICE in the last "if" statement of cancel instruction.

Indeed, when a seller wants to cancel its bids from a listing they created, the listing config account is getting closed because of the last commit in auctioneer.

Adding this condition make sure the seller wants to cancel its listing not its bids.

@akkoucai akkoucai requested a review from a team as a code owner October 26, 2022 15:39
@austbot austbot added question Usage questions (redirecting to SO) bug labels Nov 22, 2022
@austbot
Copy link
Contributor

austbot commented Nov 22, 2022

@blockiosaurus this is a fix to allow the seller to cancel bids its made against its own sale.
I'm not sure we want to handle for that case. Will close if you agree,.

@austbot
Copy link
Contributor

austbot commented Nov 22, 2022

@akkoucai what scenario would one bid on their own item?

@akkoucai
Copy link
Author

@austbot Thought you could allow that by default as I don't see why a seller shouldn't bid on its own item.
I experienced some issues with this case when I was doing some tests with the same wallet to create the auction and to bit on it.
I agree that it's uncommon though.

@samuelvanderwaal samuelvanderwaal removed the request for review from a team May 12, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug question Usage questions (redirecting to SO)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants