Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom string index support #454

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aliendrew
Copy link

  • tests and linter show no problems (npm t)
  • tests are added/updated for bug fixes and new features
  • code is properly formatted (npm run fmt)
  • description of changes is added in CHANGELOG.md
  • update .d.ts typings

Copy link
Member

@tshemsedinov tshemsedinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use intermediate variables to name logical expression parts. To optimize calculating ecpression parts use return-early pattern.

- Added custom string index support
- Optimized calculating logical expressions with return-early pattern
- Fixed: return value only checked if the index was an array
Copy link
Member

@tshemsedinov tshemsedinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can easily move this outside of class

aliendrew added a commit to aliendrew/metautil that referenced this pull request Aug 10, 2023
Bracket balance validation used in metarhia/metaschema/#454

Add bracket balance validation

Bracket balance validation used in metarhia/metaschema#454
aliendrew added a commit to aliendrew/metautil that referenced this pull request Aug 10, 2023
Bracket balance validation used in metarhia/metaschema#454
String index check moved to util.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants