Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Ruby 2.0 compatibility #3

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mwlang
Copy link

@mwlang mwlang commented Aug 16, 2013

No description provided.

@bogdanRada
Copy link

any updated on this? seems this was opened 3 years ago and there is no comment . Is this something that still needs merging? Are there any plans of merging this?

@mwlang
Copy link
Author

mwlang commented Jul 28, 2016

@bogdanRada I've moved on to prawn for generating PDF's since opening this ticket. My guess is that this project's pretty much end-of-life.

@bogdanRada
Copy link

:( that's sad to hear. Ok. I will try Prawn. Thanks for suggestion.

@mwlang
Copy link
Author

mwlang commented Jul 28, 2016

If you absolutely need pdf-writer, you can use my fork. It mostly works, but not all edge-cases covered. My initial goal was to quickly port an existing Rails 1 project to Rails 4, which was accomplished. Then we ported the PDF generation in the project to Prawn in subsequent sprints. Prawn has much better encoding support and most likely why this project's gone dormant.

@bogdanRada
Copy link

ok. Thanks. Well honestly i only needed it for measuring the width of a string using Verdana as font family, and after spending few hours trying to make this gem somehow detect the font path, i gave up and switched to prawn as you suggested. The changes are already here: https://github.com/bogdanRada/ruby-gem-downloads-badge/blob/feature/show-default-template-in-case-shields.io-down/lib/svg_template.rb#L42

Although I admit i liked this gem better because is more intuitive and uses standard Ruby classes instead of using a DSL . Prawn uses a DSL mostly but the documentation is poorly written and i had to search through the code to find what i need.

Would really love to see this gem updated honestly. The manual for this gem is really great, Everything is explained very good.

@@ -1611,6 +1620,7 @@ def adjust_wrapped_text(text, actual, width, x, just)
#
# +justification+:: :left, :right, :center, or :full
def add_text_wrap(x, y, width, text, size = nil, justification = :left, angle = 0, test = false)
raise 'wtf' if text =~ /Scottish/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This made me laugh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants