-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOBT-661: Required changes for precipitation phase accumulations #1997
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1997 +/- ##
==========================================
- Coverage 98.39% 98.37% -0.03%
==========================================
Files 124 133 +9
Lines 12212 12903 +691
==========================================
+ Hits 12016 12693 +677
- Misses 196 210 +14 ☔ View full report in Codecov by Sentry. |
In order to maintain a backlog of relevant PRs, we automatically label them as stale after 60 days of inactivity. If this PR is still important to you, then please comment on this PR and the stale label will be removed. Otherwise this PR will be automatically closed in 30 days time. |
Commenting to remove 'staleness'. |
873974b
to
46ccc84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @brhooper 👍
I've added some comments and suggestions.
improver_tests/utilities/cube_manipulation/test_manipulate_realization_dimension.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @brhooper 👍
I've happy to approve these changes, subject to the GitHub Actions failures being addressed.
…ities. Add unit tests.
…ts of new functionality.
…Add acceptance test and data for this functionality. Update checksums. Change numpy broadcasting method in plugin.
…ding acceptance tests. Update checksums.
…dimension coordinate var_name attributes does not cause an error, except where the var_name is different on a threshold coordinate. Change made to better work with the functionality of MergeCubes, which removes var_name from non-threshold dimension coordinates.
… the input cube. Update checksums for new data for this test.
b37cf83
to
f7aff40
Compare
Related to: https://github.com/metoppv/mo-blue-team/issues/661, https://github.com/metoppv/mo-blue-team/issues/671
Acceptance test data: metoppv/improver_test_data#48
Description
This PR includes a few changes which are required for the work to produce precipitation phase accumulations over longer periods.
Included changes are as follows:
combine
plugin easier to pass - test will no longer fail if coordinates on input cubes differ in thevar_name
, except if the difference is on a threshold coordinate. This mirrors, and was necessitated by, the functionality of theMergeCubes
plugin, which removes this attribute from coordinates.Testing: