Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow domains that end with a period #53

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Disallow domains that end with a period #53

merged 1 commit into from
Feb 14, 2023

Conversation

zingerj
Copy link
Contributor

@zingerj zingerj commented Apr 27, 2022

As discussed in #21

conradkirschner
conradkirschner suggested changes Feb 4, 2023
View reviewed changes
Copy link

@conradkirschner conradkirschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ending dot depends on the mail provider, from specs it's totally legal to do so.

I would suggest to make an optional check for it

@zingerj
Copy link
Contributor Author

zingerj commented Feb 6, 2023 •
edited
Loading

Is [email protected]. a valid domain name?

@mfbx9da4 mfbx9da4 merged commit b63c0bc into mfbx9da4:master Feb 14, 2023
mfbx9da4 added a commit that referenced this pull request Feb 14, 2023
@mfbx9da4
Revert "Disallow domains that end with a period (#53)"
6087ec2 
This reverts commit b63c0bc.
@mfbx9da4 mfbx9da4 mentioned this pull request Feb 14, 2023
Merged
mfbx9da4 added a commit that referenced this pull request Feb 14, 2023
@mfbx9da4
Revert "Disallow domains that end with a period (#53)" (#64)
4bb53f4 
This reverts commit b63c0bc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradkirschner conradkirschner conradkirschner requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zingerj @conradkirschner @mfbx9da4