Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoting https://git-scm.com/docs/gitignore#_pattern_format:
A slash followed by two consecutive asterisks then a slash matches
zero or more directories. For example, "
a/**/b
" matches "a/b
","
a/x/b
", "a/x/y/b
" and so on.I read this to mean that the "
/**/
" pattern should only match atdirectory boundaries, i.e. it is NOT meant to be equivalent to "
/**
".Fix this by making the last '
/
' mandatory when the preceding ".*
"regex match is non-empty.
In other words, for "
/**/
" patterns, change the resulting regex from[/].*[/]?
to
[/](.*[/])?