build: Switch GraalVM -march flag from native to compatibility
#1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`-march=native` can improve performance but will add a hard requirement for every CPU extension present on your CPU. This can cause issues with older CPUs or CPUs from different vendors (AMD vs Intel). `-march=compatibility` will ensure the best compatibility with a potential performance penalty. In my experience this is not usually noticable in applications like neo4j-migrations. If performance is a concern then another option would be to remove the flag and trust the defaults of GraalVM, which according to their docs are: `x86-64-v3 on AMD64 and armv8-a on AArch64`
|
Good change, thank you. Makes complete sense, and if someone wants to have all the optimization, they can build accordingly. |
|
@all-contributors add @medsouz for code |
|
I've put up a pull request to add @medsouz! 🎉 |
michael-simons
pushed a commit
that referenced
this pull request
Oct 17, 2024
Adds @medsouz as a contributor for code. This was requested by michael-simons [in this comment](#1488 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-march=nativecan improve performance but will add a hard requirement for every CPU extension present on your CPU. This can cause issues with older CPUs or CPUs from different vendors (AMD vs Intel).-march=compatibilitywill ensure the best compatibility with a potential performance penalty. In my experience this is not usually noticable in applications like neo4j-migrations.If performance is a concern then another option would be to remove the flag and trust the defaults of GraalVM, which according to their docs are:
x86-64-v3 on AMD64 and armv8-a on AArch64