Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polymorphic ruler version 2 #1

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Polymorphic ruler version 2 #1

wants to merge 19 commits into from

Commits on Jul 15, 2022

  1. Split update across classes 

    Modify the code of Ruler's Updater so that it is polymorphic and utilizes a pure virtual Update function.
    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    ac6c145 View commit details
    Browse the repository at this point in the history

  2. Rename sg to sign 

    As discussed, change the name of sg to sign to be more clear to developers.
    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    20b598f View commit details
    Browse the repository at this point in the history

  3. Initial changes to Ruler.h 

    Adding mpUpdater and SetUpdater to the ruler. This is assuming that Updater will still be a nested class of Ruler. I will make a later branch that will un-nest Updater and Format from Ruler to give multiple ways to proceed.

Quick Fix

Removed some faulty code from previous push

Update Ruler.h
    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    c5c7bba View commit details
    Browse the repository at this point in the history

  4. Define functions and change existing updater code

    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    3112164 View commit details
    Browse the repository at this point in the history

  5. Break into multiple files, import 

    Also detach ChooseFonts from the Updater because it is completely unrelated

quick fix
    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    5842981 View commit details
    Browse the repository at this point in the history

  6. Simplify Updater 

    Clean up ZoomInfo related code, and pull TickOutput and UpdateOutput out of Updater to be alongside TickSizes since they were separate but all serve similar purpose. If migrating them all back into Updater is a good idea, I will do so later
    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    56c2360 View commit details
    Browse the repository at this point in the history

  7. Add some includes

    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    897659e View commit details
    Browse the repository at this point in the history

  8. Merge SetUseZoomInfo into SetUpdater 

    Necessary to add SetUpdater to all rulers
    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    0d8a4d5 View commit details
    Browse the repository at this point in the history

  9. Reformatting and changing 

    Lots of changes now that Visual Studio functions correctly. Primarily turns Updater from a inner class to a friend class.
    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    0e222ef View commit details
    Browse the repository at this point in the history

  10. ZoomInfo rulers 

    Replace all uses of SetUseZoomInfo with SetUpdater
    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    bb2a44f View commit details
    Browse the repository at this point in the history

  11. Finish off SetUpdater files and prettify 

    Small edits
    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    f4e1c42 View commit details
    Browse the repository at this point in the history

  12. Comment out SetUpdater

    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    5b37bfc View commit details
    Browse the repository at this point in the history

  13. Replace SetLog with SetUpdater

    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    57fa05a View commit details
    Browse the repository at this point in the history

  14. Fix mistaken comments

    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    edd4a59 View commit details
    Browse the repository at this point in the history

  15. More comment fixes

    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    acfecca View commit details
    Browse the repository at this point in the history

  16. Uncommented code (Linker broken)

    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    c984921 View commit details
    Browse the repository at this point in the history

  17. Attempted fix of linker issues (doesn't work)

    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    986120c View commit details
    Browse the repository at this point in the history

  18. Update compilation

    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    c58b93d View commit details
    Browse the repository at this point in the history

  19. Fix scoping and variable issues

    @micpap25
    micpap25 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    330be73 View commit details
    Browse the repository at this point in the history