Linear dB Ruler Midterm-ready Changes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework update so that it is polymorphic. Break it into multiple files and allow the ruler's creator to set the updater with a unique pointer creator.
Create the virtual destructor for updater Remove circular dependencies of Updater and Ruler Streamline the dependencies of Updater and Ruler. Extract all necessary data for Updater functions down to Updater, and rework ruler calls to use this format. This allows Updater to be independent of Ruler.
Separates Ruler from RulerPanel to reduce unnecessary importing.
To be squashed into a past commit
Properly implements Custom functions and uses the LinearDb ruler as a space to test it.
Imports an old change for GSoC to separate the units of a label from its text so different fonts can be used for each.
micpap25
changed the title
A basic start on making dB ruler functional for all settings. Will proceed more when design is discussed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.