forked from audacity/audacity
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polymorphic ruler version 4 #3
Open
micpap25
wants to merge
10
commits into
master
Choose a base branch
from
polymorphic-ruler-version-4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Aug 20, 2022
-
Split update across classes and make it polymorphic within Ruler
Rework update so that it is polymorphic. Break it into multiple files and allow the ruler's creator to set the updater with a unique pointer creator.
Configuration menu - View commit details
-
Copy full SHA for 70435e7 - Browse repository at this point
Copy the full SHA 70435e7View commit details -
Streamline the dependencies of Updater and Ruler. Extract all necessary data for Updater functions down to Updater, and rework ruler calls to use this format. This allows Updater to be independent of Ruler.
Configuration menu - View commit details
-
Copy full SHA for 75a4c2d - Browse repository at this point
Copy the full SHA 75a4c2dView commit details -
Separates Ruler from RulerPanel to reduce unnecessary importing.
Configuration menu - View commit details
-
Copy full SHA for 9b94c01 - Browse repository at this point
Copy the full SHA 9b94c01View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8db980 - Browse repository at this point
Copy the full SHA a8db980View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37153d2 - Browse repository at this point
Copy the full SHA 37153d2View commit details -
Add functionality to CustomUpdater
Properly implements Custom functions and uses the LinearDb ruler as a space to test it.
Configuration menu - View commit details
-
Copy full SHA for 21e3f77 - Browse repository at this point
Copy the full SHA 21e3f77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2671400 - Browse repository at this point
Copy the full SHA 2671400View commit details -
Create SetUpdaterData function and GeneratedUpdater class to finish c…
…leaning RulerUpdater Utilize std::any to remove dependency of Ruler on functions to specifically set values for different updater types Additionally, create a GeneratedUpdater function to extract the Tick function in RulerUpdater to, for better scoping.
Configuration menu - View commit details
-
Copy full SHA for 9b1585b - Browse repository at this point
Copy the full SHA 9b1585bView commit details
Commits on Aug 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 67701c2 - Browse repository at this point
Copy the full SHA 67701c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 679b704 - Browse repository at this point
Copy the full SHA 679b704View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.