Skip to content

Commit

Permalink
Fix build version metadata generation
Browse files Browse the repository at this point in the history
  • Loading branch information
BMurri committed Aug 13, 2024
1 parent 328d3e9 commit da8d2ef
Show file tree
Hide file tree
Showing 10 changed files with 21 additions and 18 deletions.
3 changes: 2 additions & 1 deletion CromwellOnAzure.sln
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
.editorconfig = .editorconfig
after.CromwellOnAzure.sln.targets = after.CromwellOnAzure.sln.targets
CodeCoverage.runsettings = CodeCoverage.runsettings
src\CommonAssemblyInfo.cs = src\CommonAssemblyInfo.cs
src\CommonAssemblyInfo.props = src\CommonAssemblyInfo.props
src\Directory.Build.props = src\Directory.Build.props
src\Dockerfile-TriggerService = src\Dockerfile-TriggerService
EndProjectSection
EndProject
Expand Down
1 change: 1 addition & 0 deletions src/Common/Common.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<AssemblyTitle>$(Product) common library</AssemblyTitle>
</PropertyGroup>

<ItemGroup>
Expand Down
16 changes: 0 additions & 16 deletions src/CommonAssemblyInfo.cs

This file was deleted.

9 changes: 9 additions & 0 deletions src/CommonAssemblyInfo.props
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<Project>
<PropertyGroup>
<AssemblyVersion>0.0.0.0</AssemblyVersion>
<Company>Microsoft Corporation</Company>
<Product>Cromwell on Azure</Product>
<Copyright>Copyright © Microsoft Corporation</Copyright>
<VersionPrefix>$([System.Version]::Parse($(AssemblyVersion)).Major).$([System.Version]::Parse($(AssemblyVersion)).Minor).$([System.Version]::Parse($(AssemblyVersion)).Build)</VersionPrefix>
</PropertyGroup>
</Project>
1 change: 1 addition & 0 deletions src/CromwellApiClient/CromwellApiClient.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<AssemblyTitle>$(Product) Cromwell API client</AssemblyTitle>
</PropertyGroup>

<ItemGroup>
Expand Down
3 changes: 3 additions & 0 deletions src/Directory.Build.props
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<Project>
<Import Project="$(MSBuildThisFileDirectory)CommonAssemblyInfo.props"/>
</Project>
2 changes: 2 additions & 0 deletions src/TriggerService/TriggerService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

using System;
using System.Linq;
using System.Reflection;
using System.Threading.Tasks;
using Azure.Identity;
using Azure.ResourceManager;
Expand All @@ -28,6 +29,7 @@ public TriggerService()

public static async Task Main()
{
Console.WriteLine($"TriggerService Build: {Assembly.GetExecutingAssembly().GetCustomAttribute<AssemblyInformationalVersionAttribute>().InformationalVersion}");
AzureCloudConfig azureCloudConfig = null;

await Host.CreateDefaultBuilder()
Expand Down
1 change: 1 addition & 0 deletions src/TriggerService/TriggerService.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<AssemblyTitle>$(Product) Trigger Service</AssemblyTitle>
</PropertyGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<PublishSingleFile>true</PublishSingleFile>
<SelfContained>true</SelfContained>
<IncludeNativeLibrariesForSelfExtract>true</IncludeNativeLibrariesForSelfExtract>
<AssemblyTitle>$(Product) deployment utility</AssemblyTitle>
</PropertyGroup>

<PropertyGroup>
Expand Down

0 comments on commit da8d2ef

Please sign in to comment.