Skip to content

Commit

Permalink
[main > release/client/2.3] test(client): Disable ODSP targeted signa…
Browse files Browse the repository at this point in the history
…l tests (#22741)

ODSP targeted signal tests are consistently failing due to reuse of
socket references in ODSP driver. These tests can be re-enabled once
targetClientId is included in the return signal from PushChannel.

Cherry-pick of #22743
  • Loading branch information
WillieHabi authored Oct 10, 2024
1 parent 10136b8 commit 742b983
Showing 1 changed file with 13 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,20 @@ describeCompat("Targeted Signals", "NoCompat", (getTestObjectProvider) => {
let clients: SignalClient[];
let provider: ITestObjectProvider;

beforeEach("setup containers", async () => {
beforeEach("setup containers", async function () {
provider = getTestObjectProvider();

/**
* Skip targeted signal test for ODSP driver as targeting signals for clients
* that share the same websocket connection is not yet supported.
* See {@link https://dev.azure.com/fluidframework/internal/_workitems/edit/18261}
*
* TODO: Re-enable tests once {@link https://dev.azure.com/fluidframework/internal/_workitems/edit/19030} is completed.
*/
if (provider.driver.type === "odsp") {
this.skip();
}

clients = [];
for (let i = 0; i < numberOfClients; i++) {
const container = await (i === 0
Expand Down

0 comments on commit 742b983

Please sign in to comment.