-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated SingleRT flow in odsp-driver #18690
Merged
jatgarg
merged 13 commits into
microsoft:main
from
pragya91:praggarg/remove-deprecated-singlert-code
Jan 12, 2024
Merged
Remove deprecated SingleRT flow in odsp-driver #18690
jatgarg
merged 13 commits into
microsoft:main
from
pragya91:praggarg/remove-deprecated-singlert-code
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: driver
Driver related issues
area: odsp-driver
public api change
Changes to a public API
community-contribution
base: next
PRs targeted against next branch
labels
Dec 7, 2023
pragya91
force-pushed
the
praggarg/remove-deprecated-singlert-code
branch
from
December 12, 2023 01:33
0ac5fea
to
aba7227
Compare
jatgarg
reviewed
Dec 12, 2023
jatgarg
approved these changes
Dec 12, 2023
tylerbutler
added
the
release-blocking
Must be addressed before we cut and publish the next release
label
Dec 12, 2023
Marking as release blocking to make sure this isn't forgotten for 8.0. |
⯆ @fluid-example/bundle-size-tests: -442 Bytes
Baseline commit: d0d77f3 |
pragya91
force-pushed
the
praggarg/remove-deprecated-singlert-code
branch
2 times, most recently
from
December 14, 2023 21:32
73b3b8a
to
e10c4a8
Compare
pragya91
force-pushed
the
praggarg/remove-deprecated-singlert-code
branch
from
January 11, 2024 19:12
f7b33e9
to
a29b4e9
Compare
github-actions
bot
added
base: main
PRs targeted against main branch
and removed
base: next
PRs targeted against next branch
labels
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: driver
Driver related issues
area: odsp-driver
base: main
PRs targeted against main branch
community-contribution
public api change
Changes to a public API
release-blocking
Must be addressed before we cut and publish the next release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an old deprecated path of SingleRT feature in the odsp-driver code. This code was marked as deprecated in #11177 and was marked to be removed with FF version 2.0.0-internal.1.1.0.
The code being removed corresponds to an earlier version of SingleRT feature #7554 where creation of odsp-file and creation of it's sharing link was done through a single network call, by providing the enableShareLinkWithCreate boolean flag to the HostStoragePolicy of odsp-driver.
The newer version of SingleRT feature #11177 is still valid and available to use in the odsp-driver code through enableSingleRoundTripForShareLinkWithCreate boolean flag in HostStoragePolicy. No new changes are done to it.
Motivation of this PR is to cleanup the code, before I make further incremental changes in the same code path which I plan to implement in the coming week