Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated SingleRT flow in odsp-driver #18690

Merged

Conversation

pragya91
Copy link
Contributor

@pragya91 pragya91 commented Dec 7, 2023

This PR removes an old deprecated path of SingleRT feature in the odsp-driver code. This code was marked as deprecated in #11177 and was marked to be removed with FF version 2.0.0-internal.1.1.0.

The code being removed corresponds to an earlier version of SingleRT feature #7554 where creation of odsp-file and creation of it's sharing link was done through a single network call, by providing the enableShareLinkWithCreate boolean flag to the HostStoragePolicy of odsp-driver.

The newer version of SingleRT feature #11177 is still valid and available to use in the odsp-driver code through enableSingleRoundTripForShareLinkWithCreate boolean flag in HostStoragePolicy. No new changes are done to it.

Motivation of this PR is to cleanup the code, before I make further incremental changes in the same code path which I plan to implement in the coming week

@github-actions github-actions bot added area: driver Driver related issues area: odsp-driver public api change Changes to a public API community-contribution base: next PRs targeted against next branch labels Dec 7, 2023
@pragya91 pragya91 marked this pull request as ready for review December 7, 2023 02:14
@pragya91 pragya91 requested review from a team as code owners December 7, 2023 02:14
@pragya91 pragya91 force-pushed the praggarg/remove-deprecated-singlert-code branch from 0ac5fea to aba7227 Compare December 12, 2023 01:33
@tylerbutler tylerbutler added the release-blocking Must be addressed before we cut and publish the next release label Dec 12, 2023
@tylerbutler
Copy link
Member

Marking as release blocking to make sure this isn't forgotten for 8.0.

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Dec 12, 2023

@fluid-example/bundle-size-tests: -442 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 505.26 KB 505.31 KB +44 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 240.76 KB 240.79 KB +22 Bytes
loader.js 166.56 KB 166.58 KB +22 Bytes
map.js 46.62 KB 46.63 KB +11 Bytes
matrix.js 145.05 KB 145.07 KB +11 Bytes
odspDriver.js 95.67 KB 95.36 KB -323 Bytes
odspPrefetchSnapshot.js 41.58 KB 41.61 KB +22 Bytes
sharedString.js 163.94 KB 163.95 KB +11 Bytes
sharedTree.js 293.74 KB 293.74 KB No change
Total Size 1.8 MB 1.8 MB -442 Bytes

Baseline commit: d0d77f3

Generated by 🚫 dangerJS against 7e7b223

@pragya91 pragya91 force-pushed the praggarg/remove-deprecated-singlert-code branch 2 times, most recently from 73b3b8a to e10c4a8 Compare December 14, 2023 21:32
@tylerbutler tylerbutler changed the base branch from next to main January 2, 2024 18:01
@pragya91 pragya91 force-pushed the praggarg/remove-deprecated-singlert-code branch from f7b33e9 to a29b4e9 Compare January 11, 2024 19:12
@github-actions github-actions bot added base: main PRs targeted against main branch and removed base: next PRs targeted against next branch labels Jan 11, 2024
@jatgarg jatgarg merged commit 430205c into microsoft:main Jan 12, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: driver Driver related issues area: odsp-driver base: main PRs targeted against main branch community-contribution public api change Changes to a public API release-blocking Must be addressed before we cut and publish the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants